-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adjust the maximum allowed speed in our stop time validator to be consistent with MobilityData GTFS validator #6606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the maximum allowed speed in our stop time validator to be consistent with MobilityData GTFS validator #6606
Conversation
|
Btw @miklcct, do you have data sets where you run into this problem? I'm not personally against this type of a change even if you aren't facing the issue of now but this information could still be useful when we make the decision on if we should change these limits. Also, what does "running speed" mean? Is it the maximum speed or some average that takes into account slowing down, acceleration and opening/closing doors? Metro stops aren't typically that far apart so those do affect the average a bit. |
This problem hasn't been encountered in GB yet (as the maximum train speed is 225 km/h) but it may be of interest in some other countries with faster high speed trains. The 160 km/h on metro trains refer to the maximum line and train speed. However, with skip-stopping metro services, the current limit in OTP can be exceeded on those lines. The Guangzhou Metro line 18 has a 25.8 km non-stop section between Panyu and the city, so the limit is exceeded with 160 km/h running for such a long distance. It is called a high-speed metro because it is built to higher-speed rail standard, but it is regulated and operated as a metro service inside the metro network. |
|
The GTFS validator uses the following values: Route type Description Threshold, km/h
Should we do the same in OTP as well? |
|
Lets just use the GTFS validator values. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6606 +/- ##
=============================================
- Coverage 71.04% 71.03% -0.01%
- Complexity 18297 18299 +2
=============================================
Files 2005 2005
Lines 75850 75855 +5
Branches 7779 7780 +1
=============================================
+ Hits 53884 53887 +3
- Misses 19221 19224 +3
+ Partials 2745 2744 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using the same values from the MobilityData validator is a reasonable solution.
|
I've removed the skip changelog label that I added previously since this probably should belong in the changelog so it's easier for someone to figure out if this causes issues for someone. |
Summary
The maximum speed to validate stop times (where issue reports are generated) is increased for SUBWAY and RAIL modes to reflect latest technological advances.
For example, the Beijing - Shanghai high speed train now averages over 300 km/h throughout its journey, and now Guangzhou has metro lines of 160 km/h running speed.
Issue
None
Unit tests
None
Documentation
N/A
Changelog
Not needed
Bumping the serialization version id
Not needed